This change completely maintains the public API and includes no changes in code logic

I assume that all public functions were re-exported right?

I assume that all public functions were re-exported right?

yes, they are all part of __all__ in sphinx/intersphinx/__init__.py

I haven't checked again but if nothing changed since I reviewed and if everything that was public is still exported at the same location, I'm fine with that.

Do you want to make another PR where some objects are deprecated and marked as private in 9.x?

@AA-Turner please don't merge this as is yet 😅 ,
I haven't integrated #12193 into the new code

I haven't integrated #12193 into the new code

I just have; I re-split on your delineations from the current state of intersphinx.py (but kept you as the author / credit via rewriting the commit metadata).

A

I just have; I re-split on your delineations from the current state of intersphinx.py (but kept you as the author / credit via rewriting the commit metadata

Ok cool cheers, I didn't see that, just wanted to quickly write something before the CLI finished running 😄

but yeh, as long as we have double-checked that the new code matches the old, then all good from my end 👍

No worries -- better safe than sorry & all that! I've also broken up the commits that reorganise the package so it's easier to verify that everything has been moved correctly -- and I've deferred any style updates until after this PR, again in an effort to properly verify everything is all well.

A

perfect 👌

I intend to rebase-merge this as-is, but if you want me to hold off at all I'm happy to do so @chrisjsewell

I intend to rebase-merge this as-is, but if you want me to hold off at all I'm happy to do so

No thats great thanks, go ahead!